-
Notifications
You must be signed in to change notification settings - Fork 7
Added support for large strain in pyFANS #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Snapex2409
wants to merge
15
commits into
DataAnalyticsEngineering:develop
Choose a base branch
from
Snapex2409:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Snapex2409 make sure you are on the latest version of pixi by I somehow do not have permissions to push to your branch. Although I thought it should be allowed. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for large strain in pyFANS, by reading in the strain_type from the reader.
This will construct an appropriate version of MaterialManager and Solver.
The results are stored in std::variant to reduce code duplication.
Furthermore, fixed the MPI implementation when using pyFANS in micro-manager.
Issue was: when running micro-manager using MPI it will create its own processes and will manage MPI. Each resulting rank will then manage a series of pyFANS instances. However, when using pyFANS in such a setting, it "sees" that there are other ranks in MPI_COMM_WORLD and will attempt to communicate with them.
But this is wrong, as it should only run in a single rank.
Fixed by introducing a communicator variable, that is set to either MPI_COMM_WORLD or MPI_COMM_SELF.
Additionally implemented logging and serialization support.
The latter is used to implement get- and set_state for pyFANS.
Checklist:
CHANGELOG.md.